refactor: migration to ESM #201
Conversation
BREAKING CHANGE: migration to ESM
Split changes into 2 commits to keep history changes on git BREAKING CHANGE: migration to ESM
| @@ -13,7 +13,7 @@ | |||
| "test": "jest", | |||
| "test:unit": "jest --testPathIgnorePatterns test/git.integration-test.js", | |||
| "test:git-integration": "jest --testPathPattern test/git.integration-test.js", | |||
| "release": "bin/cli.js" | |||
There was a problem hiding this comment.
I hadn't noticed this - but we don't actually use this script to release any more - it could be removed.
(commit-and-tag-version is actually released with release please - very convenient for github projects, if your use-case is covered and you don't run into the many bugs it has)
There was a problem hiding this comment.
Sure. No problem. I can remove it when I return to this PR (hopefully this weekend)
For convenience I actually use it to debug the changes
|
Migration to ESM is almost complete. However I'm facing an issue. Looks like Jest does not have an stable version compatible with ESM. It currently only provides an experimental support. However not all I've read that some suggest to migrate to Vitest while others to Mocha. I've not used @TimothyJones do you have any opinion or suggestion regarding this? |
|
I feel like the community is moving towards vitest, and it's supposed to be jest compatible these days - shall we try that? |
|
And, thanks again for all your hard work on this - so so much appreciated!! |
|
No problem. To be fair, I'm partially motivated by the fix that is available in the last version 😅. Regarding Vitest, it's something I've never used, but will try to implement it (in a separate PR). |
DO NOT MERGE: Tests pending
Summary
defaults.mjs)npm run releasedoesn't work)