Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(common): include derived types in dependency graph #90

Conversation

sanketshevkar
Copy link
Member

Closes #56

Changes

  • While visiting classDeclarations, while adding super type as a dependency edge, we also add the supertype as a vertex and the classDeclaration as its dependent type so that we can include derived types of the super types in tree after we get the connected graph

Flags

Screenshots or Video

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@coveralls
Copy link

coveralls commented Feb 1, 2024

Coverage Status

coverage: 98.782%. first build
when pulling 3693114 on sanketshevkar:sanketshevkar/graph-visitor-dependencies
into 14aeb8b on accordproject:main.

@mttrbrts mttrbrts requested review from dselman and mttrbrts February 1, 2024 09:27
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We appear to have lost orphaned nodes in the graph. We should still write these (before tree-shaking).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we are losing the orphaned nodes in the graph. I've missed out the write step

writer.writeLine(1, `\`${source}\``);

above in print method. Let me fix that.

@mttrbrts mttrbrts merged commit 16d9d5a into accordproject:main Feb 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance graph.findConnectedGraph to use type hierarchy
3 participants