feat: implement RDFProxy-compliance checkers for models #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu-pl
force-pushed
the
lupl/model-checking
branch
4 times, most recently
from
8463b45 to
bd9dbab
Compare
The change introduces a separate rdfproxy.utils._typing module. Type-related functions from rdfproxy.utils.mapper_utils are moved to this module, also two new type-checking functions are added. Given the importance of type-checking model fields in RDFProxy, the functions of this module should be extensively unit-tested. Concerns #223.
lu-pl
force-pushed
the
lupl/model-checking
branch
3 times, most recently
from
ad37c41 to
8b881a1
Compare
model_traverse aims to be a generic model traversal generator function. Given a model, the function traverses all nested models and applies a function to every model. This is used e.g. in the model checker to recursively traverse all nested models and apply sanity checking functions, but potentially has other uses with RDFProxy as well.
The change introduces an extensible model checker compose pipeline for running RFDProxy-compliance checks on a model and all of its submodels. For now, only the group_by model config is checked, the checker for the model_bool config option is merely a stub. This is because the model feature will undergo breaking changes soon and is currently also conceptually in flux. See #176 and #219.
lu-pl
force-pushed
the
lupl/model-checking
branch
from
8b881a1 to
70d9c13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #108.
Concerns #223.