Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PL Graph Constructor #26

Open
wants to merge 50 commits into
base: master
Choose a base branch
from
Open

Conversation

chris-rau
Copy link

We propose pl-graph-constructor, a custom interactive element for PrairieLearn that enables students to construct graphs in a drag-and-drop interface and converts the student-entered graph into a DOT-language form to facilitate autograding.

The element provides the student with an empty canvas in which they will construct a graph. This graph can either be graded using pre- or self-defined methods, or the canvas can serve as a sketching element for the student.

In either case, a student can create nodes simply by clicking on the location at which they want to create the node. Edges can be created by selecting the node at which the edge originates and dragging toward the next node.

chris-rau and others added 30 commits September 29, 2024 18:50
…irections without multigraph; arrow on TemporaryLinks drawn for undirected edges) and removed StartLinks
Copy link
Contributor

@armandofox armandofox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi - can you tell me why there are changed files inside elements/pl-faded-parsons, since that element has nothing to do with your project?
if it is a matter of accidental whitespace being added etc, can you cleanup your PR so that these changes are not part of the commit?
thanks

@armandofox armandofox self-requested a review January 8, 2025 19:15
Copy link
Contributor

@armandofox armandofox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you shoudl not be changing infoCourse.json since this file is global to the entire STAR repo. please remove these changes from the PR. all of your project's changes should be limited to:

  • the courseInstances/ subdirectory corresponding to your project
  • the questions/ subdirectory corresponding to your project
  • the elements/ subdirectory corresponding to your project
    No other changes to files above that level should be necessary, unless there are specific files that must be added to serverFilesCourse for your element to work.
    in particular, in your PR i also notice changes to the toplevel README.md and to the elements/pl-faded-parsons. (the latter may be an artifact of the repo being out of date with respect to yours.) unless you specifically had to modify these files in order to make yours work, which i doubt, please remove those files from the commit as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants