Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue_tracker] Convert batch/normal mode toggle to tabs and implement permission control #9434

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

ay-bh
Copy link
Collaborator

@ay-bh ay-bh commented Oct 29, 2024

Brief summary of changes

  • Replaced the view toggle button with a tabbed interface using Tabs component
  • Added permission check to show Batch Edit tab only for users with issue_tracker_developer permission
  • Implemented data refresh when switching back to Browse Issues tab

Testing instructions

  1. Login as a user without issue_tracker_developer permission - verify only "Browse Issues" tab is visible
  2. Login as a user with issue_tracker_developer permission - verify both "Browse Issues" and "Batch Edit" tabs are visible
  3. Make changes in Batch Edit mode, then switch back to Browse Issues - verify data refreshes automatically

Link(s) to related issue(s)

Screenshot

image

@ay-bh ay-bh self-assigned this Oct 29, 2024
Copy link
Contributor

@christinerogers christinerogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but did not pull/test. thanks for taking care of this so quickly Ayush

@ay-bh confirm pls this doesn't create bottlenecks by loading all the data in both tabs at once, correct?

as a future enhancement we could consider hiding the Browse Issues tab for non-developers - the vertical space use doesn't make sense if it's the only tab option for end-users. @regisoc @racostas any strong feelings here?

Copy link
Contributor

@regisoc regisoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ay-bh !

  • PR rebase required.
  • This looks clean. I like it.
  • @christinerogers Agreed, tabs should be hidden for someone not having the right permission i.e. this could be completely hidden:

image

@ay-bh ay-bh requested a review from regisoc November 2, 2024 14:15
@racostas racostas added the GSOC Google Summer of Code related label Nov 3, 2024
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

  1. Tested with various uses/permissions looks good to me.
  2. The tabs yet appear when the user have only the permission "not developer" but I think this is more cosmetic and should not stop us form merging this one
    image

What do you think @regisoc , @christinerogers ?

@racostas racostas added the Passed Manual Tests PR has undergone proper testing by at least one peer label Nov 5, 2024
@regisoc
Copy link
Contributor

regisoc commented Nov 5, 2024

@racostas that is a cosmetic change, we can change it later.

@christinerogers
Copy link
Contributor

@racostas that is a cosmetic change, we can change it later.

We're all agreed this is good to go, so I've just added this item under Second followups within #9418 PR description.

Ready for your review @driusan

@christinerogers christinerogers dismissed regisoc’s stale review November 5, 2024 16:18

addressed. @regisoc confirmed in the thread

Copy link
Contributor

@regisoc regisoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christinerogers just to confirm.

@christinerogers
Copy link
Contributor

3 approvals - over to @driusan for final review.
Ideally we could get this merged during this final GSOC submission week ending Nov. 8

@driusan driusan merged commit 8e83516 into aces:main Nov 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSOC Google Summer of Code related Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue tracker] make Batch mode visible only with developer permission
5 participants