Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some new public APIs:
ip_mask_to_prefix_checked
,ipv4_mask_to_prefix_checked
andipv6_mask_to_prefix_checked
.Like in #203, the rationale for adding new functions that return an
Option
instead is so that user's may unwrap the result to trigger a compile-time error if anything is wrong.An ugly wart of const is that the
for
construct is not yet available, which means that I had to fall back to using awhile
loop + loop variable for iteration inipv6_mask_to_prefix_checked
.I understand if this change is a bit too much, as the const-ification now starts to enforce a coding style which feels a bit unidiomatic. Please, think this one through a bit and do come with feedback!
Edit: These APIs will allow us to add a const ditto of
IpNetwork::with_netmask
if we wish to do that, which is kind of nice 😊