Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update name_variants.yaml #4000

Merged
merged 36 commits into from
Dec 2, 2024
Merged

Update name_variants.yaml #4000

merged 36 commits into from
Dec 2, 2024

Conversation

mladenk42
Copy link
Contributor

I added an entry into name_variants.yaml which should modify the vanity page of "Mladen Karan" to "Vanja M. Karan"

@mbollmann
Copy link
Member

Thanks for the PR! Is this a pre-emptive measure for future publications, due to a recent name change? I am asking because I could not find any publications with the name "Vanja M. Karan".

@mladenk42
Copy link
Contributor Author

Hi. Yes exactly, it's a pre-emptive measure.

mjpost and others added 13 commits November 8, 2024 09:57
* Update to ingestion script
   - set archival default = True
   - Make sure last name isn't empty
   - Remove copyrights as attachments
   - Increment Anthology ID for non-archival papers
* Reingest Findings: EMNLP with PDFs with corrected footers
* Edit ingestion script to make use of the full name
   - Add routine for correcting upstream name mis-parsings
   - Implement "de" correction (middle → last prefix)
* Reingest all proceedings with full names
* Restore TSAR
* Name correction
* Fixed Michael Ryan Metadata: 2023.acl-long.269 2024.acl-long.862 2024.acl-long.853
* Use a here document to avoid string quoting issues
* Paper Revision{2024.hucllm-1.6}, closes acl-org#3932.

* Paper Revision: {2024.acl-tutorials.4}, closes acl-org#3929.

* Paper Revision{2024.amta-research.9}, closes acl-org#3917.

* Paper Revision{2022.bigscience-1.12}, closes acl-org#3915.

* Paper Revision{2024.sigdial-1.59}, closes acl-org#3912.

* Paper Revision{2024.naacl-long.79}, closes acl-org#3914.

* Paper Revision{2024.findings-naacl.159}, closes acl-org#3908.

* Paper Metadata: {2023.findings-emnlp.878}, closes acl-org#3926.

* Paper Metadata: {2024.acl-short.42}, closes acl-org#3925.

* Paper Metadata: {2024.acl-long.452}, closes acl-org#3924.

* Paper Metadata: {2024.findings-naacl.245}, closes acl-org#3923.

* Paper Revision: {2020.acl-main.99}, closes acl-org#3939.

* Paper Metadata: {2020.acl-main.99}, closes acl-org#3938.

* Paper Metadata: 2024.ml4al-1.24, closes acl-org#3910.

* Paper Metadata: 2024.semeval-1.263, closes acl-org#3919.

* Paper Metadata: {D19-5532}, closes acl-org#3922.

* Paper Metadata: {2024.teachingnlp-1.11}, closes acl-org#3907.

* Paper Metadata: 2024.acl-demos.38, closes acl-org#3851.

* Paper Metadata: 2024.acl-long.784, closes acl-org#3850.

* Paper Metadata: {2024.acl-long.849}, closes acl-org#3838.

* Paper Revision: {2024.sigturk-1.7}, closes acl-org#3945.

* Paper Revision{2024.naacl-srw.28}, closes acl-org#3944.

* Paper Revision 2024.acl-tutorials.3, closes acl-org#3943.

* Paper Revision: {2024.acl-long.759}, closes acl-org#3940.

* Paper Metadata: {2024.acl-tutorials.6}, closes acl-org#3928.

* Paper Metadata: 2024.konvens-main.28, closes acl-org#3941.

* Paper Metadata: 2024.findings-acl.711, closes acl-org#3947.

* Paper Metadata: 2024.ml4al-1.8, closes acl-org#3904.

* Paper Metadata: {2024.ml4al-1.18}, closes acl-org#3840.

* Paper Metadata: 2024.sdp-1.17, closes acl-org#3727.

* Paper Metadata: {2024.sigmorphon-1.5}, closes acl-org#3723.

* Author Metadata: {Patrick-H-Chen}, closes acl-org#3489.

* Author Metadata: Shubham Nigam, closes acl-org#3493.

* Author Metadata: Taha Aksu, closes acl-org#3495.

* Author Metadata: Li Zhang, closes acl-org#3371.

* Paper Revision: {2024.clasp-1.8}, closes acl-org#3958.

* Paper Revision{2024.naacl-short.58}, closes acl-org#3960.

* Paper Revision: {2024.ml4al-1.9}, closes acl-org#3962.

* Paper Revision{2024.americasnlp-1.4}, closes acl-org#3966.

* Paper Revision{2024.acl-long.15}, closes acl-org#3967.

* Author metadata correction for 2024.sighan-1.3, closes acl-org#3964.

* Paper Metadata: Maarten de Rijke, closes acl-org#3811.

* Paper Revision 2024.nlp4convai-1.4, closes acl-org#3969.

* Paper Revision 2024.acl-long.488, closes acl-org#3970.

* Paper Revision 2024.findings-acl.845, closes acl-org#3971.

* Paper Revision{2023.acl-long.507}, closes acl-org#3972.

* Paper Revision{2023.acl-long.507}, closes acl-org#3972.

* Paper Metadata: 2024.acl-long.415, closes acl-org#3977.

* Paper Metadata: 2024.nlp4call-1.7, closes acl-org#3980.

* Author Metadata: Abdul Hameed Azeemi, closes acl-org#3979.

* Fix author order in 2024.acl-srw.22

* Name disambiguation for Patrick Haller

* Gertjan van Noord

* Remove attachment

* Li Zhang correction, closes acl-org#3371.

* Remove software link, closes acl-org#3261.

* Remove attachments from 2024.findings-emnlp.479

---------

Co-authored-by: Matt Post <[email protected]>
Co-authored-by: Dan Gildea <dgildea>
Co-authored-by: Matt Post <[email protected]>
@mjpost mjpost added this to the 2024Q4 milestone Nov 18, 2024
@anthology-assist
Copy link
Collaborator

If it's pre-emptive, we will need to confirm that the new name is what's on the pdf. Please let us know once the paper is published.

@anthology-assist anthology-assist added the waiting waiting for a response from the submitter label Nov 29, 2024
@mladenk42
Copy link
Contributor Author

mladenk42 commented Nov 29, 2024 via email

@mjpost
Copy link
Member

mjpost commented Dec 2, 2024

To clarify: this is not just preemptive, but is also a partial commit for a name change on existing PDFs. We can change the metadata for this PR, and update the PDFs (and their hashes) in a separate request.

@mjpost
Copy link
Member

mjpost commented Dec 2, 2024

The diff here is huge. I'm not sure why, it's not locally.

@mjpost
Copy link
Member

mjpost commented Dec 2, 2024

My only guess for the huge diff (136 miles) is that, with a remote PR like this, the diff doesn't update against the target branch (master), but only against the original checkpoint. If so, I'm not sure if this is by design or is a bug.

Copy link
Member

@mjpost mjpost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is massive (it shows 136 files changed), but locally, it is a much smaller subset, just the files that have affected papers. I am hoping the diff is just a bug.

@mjpost mjpost merged commit 8f3c555 into acl-org:master Dec 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting waiting for a response from the submitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.