Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check that collection ID matches filename #4467

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

mbollmann
Copy link
Member

Adds an explicit check for the implicit assumption we currently make that XML filenames must match the collection IDs they contain.

Should prevent issue like #4458

@mbollmann mbollmann requested review from mjpost and nschneid January 22, 2025 15:18
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.57%. Comparing base (e31ad50) to head (84afc3a).
Report is 35 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4467   +/-   ##
=======================================
  Coverage   92.56%   92.57%           
=======================================
  Files          32       32           
  Lines        2301     2304    +3     
=======================================
+ Hits         2130     2133    +3     
  Misses        171      171           
Files with missing lines Coverage Δ
python/acl_anthology/collections/collection.py 95.40% <100.00%> (+0.16%) ⬆️

Copy link
Member

@mjpost mjpost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but that script isn't quite yet using the official module

@mbollmann
Copy link
Member Author

@mjpost Yes, but the build uses it and will fail if something like this happens again :)

@mbollmann mbollmann merged commit f950af8 into master Feb 3, 2025
14 checks passed
@mbollmann mbollmann deleted the python-add-collection-id-check branch February 3, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants