pahole: expand named typedefs if expanding types is requested

[wafgo]

If your code contains named typedefs like

typedef struct foo_s {
/some stuff here/
}foo;

and your run pahole with something like pahole -E -C foo it only prints something like this

typedef struct foo_s foo

I think what the user would like (at least this is what I was expecting) is that the typedef is expanded.

I know that this is irrelevant for the linux kernel because nobody is doing such silly stuff there. But there is a lot of strange software out there which typedefs nearly every structure for some reason.

I think applying this patch would make pahole -E more intuitive

Signed-off-by: Wadim Mueller [email protected]

[xaizek]

It used to print definition of the structure in this case and now even -E doesn't provide the previous behaviour. Mind that if you use the same name twice (quite common):

typedef struct foo {
    // ...
} foo;

the only way to see the definition seems to be to list all of them and find the needed one in the output (-C "struct foo" doesn't work), this makes pahole much less convenient to use in this situation.

EDIT: actually, looks like it works fine when struct is defined in typedef statement. It's a separate typedef which doesn't show the full struct and maybe it shouldn't.

[xaizek]

Needed to use pahole and hit this issue again. There should be some way to show struct foo in this case (same-name struct defined in a typedef). It's listed in the output of --structs, mentioned in the printed typedef struct foo foo, but is otherwise unaccessible. If not by default on -E, maybe when it's passed twice (-E -E).