-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: DNS API for IONOS cloud #5110
Feature: DNS API for IONOS cloud #5110
Conversation
Welcome |
44d02b9
to
adc8031
Compare
Hi @Neilpang, can you please take a look when you have a chance ? The DNS tests are passing successfully: https://github.com/ionos-cloud/acme.sh/actions/runs/8941008104 To make the tests pass, I had to make some changes to the acmetest project so that the TXT record content is randomized: acmesh-official/acmetest#26 For now, this PR uses my own fork, as you can see here: https://github.com/ionos-cloud/acme.sh/blob/add_ionos_cloud_script/.github/workflows/DNS.yml#L70. I have created a PR in the acmetest repo as well: acmesh-official/acmetest#26 Also how can I update the documentation? |
@Neilpang it's removed now. However, as I mentioned above, this will make DNS tests fail. acmesh-official/acmetest#26 is needed to make them pass, because it seems like somehow a test case starts before the previous one removes the TXT record. Inserting a TXT record with the same name and the same content is not allowed by our API ( maybe it's not the case for other DNS providers), so a non OK response is returned. |
Thanks for merging the acmetest PR. Here is the successful run for the latest triggered action: https://github.com/ionos-cloud/acme.sh/actions/runs/8969436076 |
@Neilpang I just wanted to draw your attention to this PR. Any thoughts ? |
This change set extends the existing DNS API script for IONOS dns_ionos.sh to support the IONOS Cloud API. IONOS users have two alternatives for managing their DNS zones: the IONOS Cloud API and the IONOS DNS API (which is supported by the current implementation). The objective is to allow users of the IONOS Cloud API to also use the script.
As explained in the script header comment, the script decides which API to use based on the provided credentials. If
IONOS_PREFIX
andIONOS_SECRET
are provided, the script will use the IONOS DNS API, else ifIONOS_TOKEN
is provided the script will use the IONOS Cloud API.Note: This contribution is done by IONOS DNS cloud team, the team responsible directly for the service.