-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Processing of CoNLL comments into CoNLL-RDF + CoNLL-U Plus Support #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This roughly refers to acoli-repo/conll#1 |
Tested with existing pipelines. Handling of comments does not seem to interfere with other functionalities. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arbitrary CoNLL comments
This implements metadata support for CoNLL when transforming to CoNLL-RDF. All comments in the CoNLL format that are lead by a hashmark will be written to the rdf graph as a rdfs:comment property of the sentence head node.
For example, this:
will result in this CoNLL-RDF:
Also note, that we still directly transport any hashmark-lead comments to the CoNLL-RDF for backwards compartability. Also, when exporting CoNLL with the CoNLLRDFFormatter, we will write a
global.columns
comment to the first line of each sentence to improve ease of handling when reusing the CoNLLStreamExtractor, see below.CoNLL-U Plus support
In addition to the general metadata support, we now support automatic column setting with the new CoNLL-U Plus Format
If the user does not supply any column names when calling the
CoNLLStreamExtractor
, we will try to find aglobal.columns
comment in ONLY the first line and, if present, will use this as column names. Also, if using the CoNLLRDFFormatter to write conll again, we will search both raw conll comments and the rdfs:comment property for such aglobal.columns
comment, IF the user did not provide column names themselves. They overwrite each other with following priority: -conll ARGS > rdfs:comment > raw conll comment.