This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
enhance: strip k8s scheduling details from app objects #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njhale
requested review from
thedadams,
iwilltry42,
keyallis,
g-linville and
tylerslaton
njhale
force-pushed
the
enhance-strip-scheduling-field
branch
3 times, most recently
from
928608c to
ccf37c2
Compare
njhale
force-pushed
the
enhance-strip-scheduling-field
branch
7 times, most recently
from
c88c8bd to
72bf177
Compare
keyallis
approved these changes
Jan 30, 2024
Comment on lines
+76
to
+53
| // AppToAppInstance converts an App to a [v1.AppInstance] and returns the result. | ||
| func AppToAppInstance(in *App) *v1.AppInstance { |
There was a problem hiding this comment.
Might be worth mentioning in the comment on this function that it drops some fields, or maybe explicitly name them
Comment on lines
+32
to
+34
| // Ensure that AppInstanceStatus fields not surfaced by AppStatus are preserved. | ||
| // Note: This is necessary because obj has been translated from an apiv1.App before being passed to this method, | ||
| // and since the AppStatus is a subset of the AppInstanceStatus, the App |
There was a problem hiding this comment.
Seems like maybe this comment got cut short
thedadams
reviewed
Jan 30, 2024
njhale
force-pushed
the
enhance-strip-scheduling-field
branch
3 times, most recently
from
4d94148 to
3e8237f
Compare
Hide k8s scheduling details from end-users by removing the scheduling status field from the `Apps` API. The scheduling status field of `AppInstances` is preserved as an internal implementation detail. Signed-off-by: Nick Hale <[email protected]>
njhale
force-pushed
the
enhance-strip-scheduling-field
branch
from
3e8237f to
fc7939c
Compare
tylerslaton
approved these changes
Jan 30, 2024
thedadams
approved these changes
Jan 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide k8s scheduling details from end-users by removing the
scheduling status field from the
AppsAPI. The scheduling status fieldof
AppInstancesis preserved as an internal implementation detail.Addresses #2457 for runtime.