Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding rust install #77

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

augustweinbren
Copy link

Added installation instruction for rust from their site.
This is needed to create .cargo directory.

@mbsantiago
Copy link
Collaborator

Hi @augustweinbren! Huge thanks for the PR. Sorry for asking a possibly simple question, but I'm not sure where the .cargo directory is needed, could you explain please?

@augustweinbren
Copy link
Author

It's down here

@mbsantiago
Copy link
Collaborator

hehe you are absolutely right! I thought the uv installer would create the directory if it didn't exist, but did you run into this issue when installing it?

@mbsantiago
Copy link
Collaborator

I'm not really sure why I included the line source $HOME/.cargo/env, it does not seem to be needed. We could remove it and avoid the rustup installation to keep the setup lean. What do you think? Many thanks again for pointing to this issue!

@augustweinbren
Copy link
Author

augustweinbren commented Feb 6, 2025

Looks like uv is a rust-based Python packaging software, so it seems to make sense to have it?

@mbsantiago
Copy link
Collaborator

Good point! It seems that uv is shipped as a pre-built binary (for most platforms) so we don't need the rust toolchain for compilation. Sorry for being so hesitant, just thinking about avoiding including additional installation/setup steps if not strictly necessary. I'll try to install acoupi on an RPi without the source $HOME/.cargo/env line to see if installation works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants