Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Role attribute has valid value" [674b10]: how to enforce WCAG mappings #1862

Closed
wants to merge 3 commits into from
Closed

"Role attribute has valid value" [674b10]: how to enforce WCAG mappings #1862

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d856b7
Add non-automatable expection
Jym77 Jun 16, 2022
fb40435
Merge branch 'develop' into role-attribute-mapping
Jym77 Jun 23, 2022
1e2a601
Merge branch 'develop' into role-attribute-mapping
Jym77 Jul 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions _rules/role-attribute-valid-value-674b10.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,14 @@ This rule applies to any `role` attribute for which all the following are true:
- the attribute has a value that is neither empty ("") nor only [ASCII whitespace][]; and
- the attribute is specified on an [HTML or SVG element][] which is not [programmatically hidden][].

## Expectation
## Expectation (mapping to 4.1.2)

Each test target either has at least one token which is a valid value corresponding to a non-abstract role from [WAI-ARIA Specifications][]; or the test target is not a [user interface component](https://www.w3.org/TR/WCAG21/#dfn-user-interface-components)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both the UIC and the structure definitions are ambiguous. UIC because it is not clear who is meant by "users", and "structure" for not specifying what "organize" means.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can replace UIC by our definition of Instrument but that would require to define the objective, so I'm not sure it would actually work 😕


## Expectation (mapping to 1.3.1)

Each test target either has at least one token which is a valid value corresponding to a non-abstract role from [WAI-ARIA Specifications][]; or the test target has not a [structure](https://www.w3.org/TR/WCAG21/#dfn-structure) conveyed through presentation.
Comment on lines +40 to +46
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposing two different versions, depending on the mapping we want to have.
I feel the 4.1.2 version is better, but also that the mapping is weaker (since less roles are UI components).

The 4.1.2 version would accept a mispelled list while the 1.3.1 version would reject it…

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm struggling to understand how any test target could meet the second part of the expectation version 1.3.1. If the test target must not be programatically hidden then it always have structure conveyed through presentation (because it will always be organised in relation to other parts of the web page).


Each test target has at least one token which is a valid value corresponding to a non-abstract role from [WAI-ARIA Specifications][].

## Assumptions

Expand Down