Fix STRDS removement and unregistration of rasters in STRDS #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anikaweinmann
changed the title
anikaweinmann
changed the title
added 17 commits
June 16, 2022 10:37
metzm
reviewed
Jun 17, 2022
| source_path, target_path, | ||
| msg="merge mapsets. Error in linking") | ||
|
|
||
| def _copy_folder( |
There was a problem hiding this comment.
Why not using shutil.copytree()?
metzm
reviewed
Jun 17, 2022
| for col in columns: | ||
| if col not in skip_columns: | ||
| update_statement = f"UPDATE {table_name} SET {col} = " \ | ||
| f"REPLACE({col}, '{source_mapset}', '{target_mapset}')" |
There was a problem hiding this comment.
What if the name of the map and of the source mapset are the same, e.g. elevation@elevation? This would then not only replace the mapset name, but also the map name?
|
What about creating a list of space-time datasets to be copied and using |
marcjansen
reviewed
Jun 17, 2022
| for col in columns: | ||
| if col not in skip_columns: | ||
| update_statement = f"UPDATE {table_name} SET {col} = " \ | ||
| f"REPLACE({col}, '{source_mapset}', '{target_mapset}')" |
There was a problem hiding this comment.
Suggested change
| f"REPLACE({col}, '{source_mapset}', '{target_mapset}')" | |
| f"REPLACE({col}, '@{source_mapset}', '@{target_mapset}')" |
untested, make sure to verify 🙈
There was a problem hiding this comment.
Works for the column "id" but not for the column "mapset".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The STRDS support is adjusted so that the tgis sqlite.db is copied by creating a temporare mapset and copies (with renamed mapset) the tgis sqlite.db by the mapset merge.
This can only work if OSGeo/grass#2447 is merged.