Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test super-linter workflow #536

Merged
merged 20 commits into from
Jul 11, 2024
Merged

Test super-linter workflow #536

merged 20 commits into from
Jul 11, 2024

Conversation

mmacata
Copy link
Member

@mmacata mmacata commented Jun 20, 2024 •
edited
Loading

Make use of super-linter via mundialis/github-workflows#27

  • added config files for markdownlint and shellcheck
  • added inline exceptions for markdownlint, shellcheck and hadolint (docker)
  • lint (with help of super-linter)
    • yaml (VALIDATE_YAML)
    • markdown (VALIDATE_MARKDOWN)
    • github workflows (VALIDATE_GITHUB_ACTIONS)
    • json (VALIDATE_JSON)
    • shell / bash (VALIDATE_BASH, VALIDATE_BASH_EXEC)
    • renovate (VALIDATE_RENOVATE)
    • Dockerfiles (VALIDATE_DOCKERFILE_HADOLINT)
  • Linter were added but no adjustments needed for VALIDATE_XML, VALIDATE_CSS, VALIDATE_HTML, VALIDATE_JAVASCRIPT_ES, VALIDATE_JAVASCRIPT_STANDARD, VALIDATE_POWERSHELL
  • ace READMEs which were deleted were (already) moved to actinia-org/ace
  • merged scripts on how to create swagger docs

@mmacata mmacata mentioned this pull request Jul 10, 2024
Merged
@mmacata mmacata marked this pull request as ready for review July 10, 2024 14:31
anikaweinmann
anikaweinmann approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@anikaweinmann anikaweinmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Just a few little things Ii noticed. Please have a look at the failing tests.

docker/actinia-core-dev/Dockerfile Outdated Show resolved Hide resolved
docker/actinia-core-tests/Dockerfile Outdated Show resolved Hide resolved
logging.md Show resolved Hide resolved
@mmacata mmacata merged commit b590dfa into actinia-org:main Jul 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anikaweinmann anikaweinmann anikaweinmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmacata @anikaweinmann