Stac result items #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-stac-plugin into StacResultItems
mmacata
reviewed
Mar 25, 2022
There was a problem hiding this comment.
Very clean and well structured, thanks!
Please fix year in files to 2022 and sort imports according to https://peps.python.org/pep-0008/#imports
Imports should be grouped in the following order:
Standard library imports.
Related third party imports.
Local application/library specific imports.
in affected files. (I didn't make suggestions to all of them)
Co-authored-by: Carmen Tawalika <[email protected]>
Co-authored-by: Carmen Tawalika <[email protected]>
Co-authored-by: Carmen Tawalika <[email protected]>
Co-authored-by: Carmen Tawalika <[email protected]>
Co-authored-by: Carmen Tawalika <[email protected]>
Co-authored-by: Carmen Tawalika <[email protected]>
Co-authored-by: Carmen Tawalika <[email protected]>
mmacata
requested changes
Mar 29, 2022
mmacata
approved these changes
Sep 3, 2023
|
I will merge this one and adress the tests in a separate MR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.