Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add OwnerReference to created resources #3902

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

foyerunix
Copy link

Hello,

This is basically an alternative implementation of #3575 taking into account the points raised by @nikola-jokic.

It improves upon it by:

Please note that I had to move the namespace where we create the autoscalinglisteners from the namespace where we run the controller to the namespace where we run the runners. Without this change, the autoscalinglisteners cannot be owned by their respective AutoscalingRunnerSet. If this is incorrect, please advise on the alternative approach so I can rework my PR accordingly.

It is running in my environment with no issues so far.

Best Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant