-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[macOS] Add Colima tool #6285
[macOS] Add Colima tool #6285
Conversation
@@ -203,7 +203,8 @@ | |||
"./provision/core/pypy.sh", | |||
"./provision/core/pipx-packages.sh", | |||
"./provision/core/bicep.sh", | |||
"./provision/core/graalvm.sh" | |||
"./provision/core/graalvm.sh", | |||
"./provision/core/colima.sh" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are deprecating macOS-10.15, no need to add colima for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I removed it for the 10.15 version
@@ -0,0 +1,6 @@ | |||
#!/bin/bash -e -o pipefail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this file and use brew section in toolset file - https://github.com/actions/runner-images/blob/main/images/macos/toolsets/toolset-12.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I switched to toolset json
@@ -182,7 +182,8 @@ $toolsList += @( | |||
(Get-GHCVersion), | |||
(Get-CabalVersion), | |||
(Get-StackVersion), | |||
(Get-SwiftFormatVersion) | |||
(Get-SwiftFormatVersion), | |||
(Get-ColimaVersion) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bogdan-damian-bgd should it be in the runtime section instead as "Colima - container runtimes on macOS (and Linux) with minimal setup"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, directly from a naming point of view it should be in 'Language and Runtimes'.
On the other hand, if we consider it as some kind of replacement for Docker (which is also labeled as a container runtime) and try to be consistent with the location of Docker within the ReadMe sections for Windows and Linux, then it also makes some sense to stay in this section as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, if we'd like to be consistent then it's fine
/azp run macos11, macos12 |
Azure Pipelines successfully started running 2 pipeline(s). |
Description
Colima tool added to macOS
Related issue:
#6216
Virtual environments affected
Check list