Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Add Colima tool #6285

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Conversation

bogdan-damian-bgd
Copy link
Contributor

@bogdan-damian-bgd bogdan-damian-bgd commented Sep 22, 2022

Description

Colima tool added to macOS

Related issue:

#6216

Virtual environments affected

  • macOS 10.15
  • macOS 11
  • macOS 12

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

@bogdan-damian-bgd bogdan-damian-bgd requested a review from a team September 22, 2022 21:24
@@ -203,7 +203,8 @@
"./provision/core/pypy.sh",
"./provision/core/pipx-packages.sh",
"./provision/core/bicep.sh",
"./provision/core/graalvm.sh"
"./provision/core/graalvm.sh",
"./provision/core/colima.sh"
Copy link
Contributor

@ddobranic ddobranic Sep 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are deprecating macOS-10.15, no need to add colima for it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I removed it for the 10.15 version

@@ -0,0 +1,6 @@
#!/bin/bash -e -o pipefail
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I switched to toolset json

@@ -182,7 +182,8 @@ $toolsList += @(
(Get-GHCVersion),
(Get-CabalVersion),
(Get-StackVersion),
(Get-SwiftFormatVersion)
(Get-SwiftFormatVersion),
(Get-ColimaVersion)
Copy link
Contributor

@miketimofeev miketimofeev Sep 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bogdan-damian-bgd should it be in the runtime section instead as "Colima - container runtimes on macOS (and Linux) with minimal setup"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, directly from a naming point of view it should be in 'Language and Runtimes'.

On the other hand, if we consider it as some kind of replacement for Docker (which is also labeled as a container runtime) and try to be consistent with the location of Docker within the ReadMe sections for Windows and Linux, then it also makes some sense to stay in this section as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, if we'd like to be consistent then it's fine

@miketimofeev
Copy link
Contributor

/azp run macos11, macos12

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants