Merge pull request #226 from activeadmin/fix_gem_build_warnings

Fix `gem build` warning about unbounded dep

.travis.yml

@@ -1,7 +1,7 @@
 language: ruby
 sudo: false
 before_install:
-  - gem update --system 3.1.3
+  - gem update --system 3.2.0.rc.1
   - gem install bundler:2.1.4
 rvm:
   - 2.5.8

Gemfile.lock

@@ -3,7 +3,7 @@ PATH
   specs:
     arbre (1.3.0)
       activesupport (>= 3.0.0, < 6.1)
-      ruby2_keywords (>= 0.0.2)
+      ruby2_keywords (>= 0.0.2, < 1.0)
 
 GEM
   remote: http://rubygems.org/

arbre.gemspec

@@ -22,5 +22,5 @@ Gem::Specification.new do |s|
   s.required_ruby_version = '>= 2.5'
 
   s.add_dependency("activesupport", ">= 3.0.0", "< 6.1")
-  s.add_dependency("ruby2_keywords", ">= 0.0.2")
+  s.add_dependency("ruby2_keywords", ">= 0.0.2", "< 1.0")
 end

spec/gemspec_spec.lint.rb

@@ -13,7 +13,21 @@
   end
 
   it "has no warnings" do
-    expect(build[1]).not_to include("WARNING")
+    output = build[1]
+
+    if RUBY_ENGINE == "jruby"
+      annoying_jruby_warnings = [
+        /WARNING: An illegal reflective access operation has occurred/,
+        /WARNING: Illegal reflective access by org.jruby.ext.openssl.SecurityHelper \(file:.*\/jopenssl\.jar\) to field java\.security\.MessageDigest\.provider/,
+        /WARNING: Please consider reporting this to the maintainers of org\.jruby\.ext\.openssl\.SecurityHelper/,
+        /WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations/,
+        /WARNING: All illegal access operations will be denied in a future release/
+      ]
+
+      output = output.split("\n").reject { |line| annoying_jruby_warnings.any? { |warning| warning.match?(line) } }.join("\n")
+    end
+
+    expect(output).not_to include("WARNING"), output
   end
 
   it "succeeds" do

tasks/lint.rake

@@ -57,7 +57,7 @@ require 'rubocop/rake_task'
 RuboCop::RakeTask.new
 
 desc "Lints ActiveAdmin code base"
-task lint: ["rubocop", "lint:missing_trailing_carriage_return"]
+task lint: ["rubocop", "lint:missing_trailing_carriage_return", "lint:rspec"]
 
 namespace :lint do
   desc "Check for missing trailing new lines"
@@ -66,4 +66,16 @@ namespace :lint do
 
     MissingTrailingCarriageReturn.new.run
   end
+
+  desc "RSpec specs for linting project files"
+  task :rspec do
+    puts "Linting project files..."
+
+    sh(
+      "bundle",
+      "exec",
+      "rspec",
+      *Dir.glob("spec/*.lint.rb")
+    )
+  end
 end