Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set new error to replace ArgumentError #1478

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Set new error to replace ArgumentError #1478

wants to merge 9 commits into from

Commits on Feb 5, 2024

  1. chore: reorganize regex on search specs for better reading

    @zokaibr
    zokaibr committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    7a226be View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. feat: add an error class for invalid search

    @zokaibr
    zokaibr committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    3a47cd6 View commit details
    Browse the repository at this point in the history

  2. refact: update Ransack::Search 

    It was updated to raise InvalidSearchError on searching and sorting instead of ArgumentError
    @zokaibr
    zokaibr committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    d8979df View commit details
    Browse the repository at this point in the history

  3. test: update ActiveRecord Ransack adapter 

    It was updated to ensure Ransack is raising InvalidSearchError when calling ransack! method
    @zokaibr
    zokaibr committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    a25d577 View commit details
    Browse the repository at this point in the history

  4. docs: set a sidebar position for Getting Started->Search Matches page

    @zokaibr
    zokaibr committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    3374392 View commit details
    Browse the repository at this point in the history

  5. docs: set a sidebar position for Getting Started->Sorting page

    @zokaibr
    zokaibr committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    1c40340 View commit details
    Browse the repository at this point in the history

  6. docs: move error handling to a specic area on Getting Started 

    This error handling is an important configuration and need to have more atention
    @zokaibr
    zokaibr committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    9fca4e7 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into new_search_error

    @zokaibr
    zokaibr authored Feb 14, 2024
    Configuration menu
    Copy the full SHA
    c984822 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. Merge branch 'main' into new_search_error

    @scarroll32
    scarroll32 authored Apr 27, 2024
    Configuration menu
    Copy the full SHA
    a33f22c View commit details
    Browse the repository at this point in the history