Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI-7198 - Fix running the CLI with Node 16 #18

Merged

Conversation

antoinetissier
Copy link
Collaborator

The problem is explained in the ticket description: UI-7198

I haven't found a better solution than to call process.exit manually.
In particular, I have researched things like "yargs Node 16 process not exiting", and the polyfill warnings, and I did not find any related issue.

To test, having this merged would have been helpful, so I'm glad we're in the process of adding it.
In the meantime, you can use npm link:

// Starting from activeui-migration:
git co personal/a.tissier/UI-7198-fix-cli-with-node-16
git pull
yarn && yarn build
npm link
cd ..
mkdir migration_test
npm init
npm link activeui-migration
npx migrate -i ../activeui-migration/src/__test_resources__/aui4_ui_folder.json -s ../activeui-migration/src/__test_resources__/servers.json -o output.json

@antoinetissier antoinetissier requested a review from Nouzbe as a code owner April 5, 2022 13:00
@antoinetissier antoinetissier added the bug Something isn't working label Apr 5, 2022
Copy link
Collaborator

@Nouzbe Nouzbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems very surprising to me. A quick Google Search did not yield any result for me, but could you find something about Yargs not exiting in recent versions of Node?

@Nouzbe Nouzbe assigned antoinetissier and unassigned Nouzbe Apr 6, 2022
@antoinetissier
Copy link
Collaborator Author

antoinetissier commented Apr 8, 2022

I didn't find anything related between Yargs not exiting and recent versions of Node.
@messaooudi any chance this rings a bell to you ?

@messaooudi
Copy link
Contributor

messaooudi commented Apr 11, 2022

@antoinetissier the only thing related to this prob that I found : lukeed/uvu#124.

Copy link
Contributor

@messaooudi messaooudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since I don't have any better suggestions 👍🏻.

Copy link
Collaborator

@Nouzbe Nouzbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite satisfying, but let's get it.

@Nouzbe Nouzbe assigned antoinetissier and unassigned Nouzbe Apr 20, 2022
@antoinetissier antoinetissier merged commit fb66cd5 into main Apr 20, 2022
@antoinetissier antoinetissier deleted the personal/a.tissier/UI-7198-fix-cli-with-node-16 branch April 20, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants