Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

980.2 Duplicate modal-handling code in some of the codebase #993

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

980.2 Duplicate modal-handling code in some of the codebase #993

wants to merge 4 commits into from

Conversation

mattburnett-repo
Copy link
Contributor

Contributor checklist

Description

This PR addresses a problem first described in issue 980, at this link #980 (comment)

Code to consolidate the open / close functionality that is copy-pasted throughout the modal codebase is implemented in this PR. A few modals (CommandPalette, EditAboutOrganizations and Share modals) contain this new functionality.

Related issue

@mattburnett-repo
Local commit.
f951acf 
Added useModalHandlers.ts
Mods to modals.ts
Implemented first round of new modal handlers.
@mattburnett-repo
Local commit:
a013346 
Cleanup to app.vue
@mattburnett-repo
Local commit to test pre-commit installation.
254fb6e
@mattburnett-repo
908.2:
986c322 
Implemented central modal open and close methods.
Modified ModalBase.vue to replace background div with HeadlessUI DialogBackground element.
@github-actions GitHub Actions
Copy link
Contributor

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@netlify Netlify
Copy link

netlify bot commented Oct 20, 2024 •
edited
Loading

✅ Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit 986c322
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/67151b7629722c0008a22cd4
😎 Deploy Preview https://deploy-preview-993--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andrewtavis andrewtavis self-requested a review October 21, 2024 11:04
@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewtavis andrewtavis Awaiting requested review from andrewtavis

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattburnett-repo @andrewtavis