Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performances of users list #27

Open
srosset81 opened this issue Sep 18, 2022 · 2 comments
Open

Improve performances of users list #27

srosset81 opened this issue Sep 18, 2022 · 2 comments

Comments

@srosset81
Copy link
Contributor

On old mobiles, when we have more than 100 users, it becomes slow to scroll through users (also when we want to share an event)

This is probably related to the fact images are too big.

But using https://github.com/bvaughn/react-window could help as well.

@srosset81
Copy link
Contributor Author

Done 476cd67

@srosset81
Copy link
Contributor Author

I had to revert the commit because we cannot use useState within rows when using react-window. When we toggled on an invitation, it didn't appear toggled on.

I will have to keep the state of clicked contacts one level higher. (https://stackoverflow.com/questions/72405479/react-window-rows-call-usestate)

But since I don't want this to enter into conflict with #22, I will wait for @andreipopa-who to finish his PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant