add last sync functionality

actualbudget · Jan 28, 2025 · 28d05e6 · 28d05e6
1 parent f35f541
commit 28d05e6
Show file tree

Hide file tree

Showing 8 changed files with 35 additions and 12 deletions.
diff --git a/packages/desktop-client/src/components/Modals.tsx b/packages/desktop-client/src/components/Modals.tsx
@@ -386,12 +386,7 @@ export function Modals() {
           return <PostsOfflineNotification key={name} />;
 
         case 'synced-account-edit':
-          return (
-            <EditSyncAccount
-              key={name}
-              account={options.account}
-            />
-          );
+          return <EditSyncAccount key={name} account={options.account} />;
 
         case 'account-menu':
           return (

diff --git a/packages/desktop-client/src/components/banksync/AccountRow.tsx b/packages/desktop-client/src/components/banksync/AccountRow.tsx
@@ -2,12 +2,23 @@
 import React, { memo } from 'react';
 import { useTranslation } from 'react-i18next';
 
+import { format } from 'loot-core/src/shared/months';
 import { type AccountEntity } from 'loot-core/src/types/models';
 
+import { useDateFormat } from '../../hooks/useDateFormat';
 import { theme } from '../../style';
 import { Button } from '../common/Button2';
 import { Row, Cell } from '../table';
 
+const tsToString = (ts, dateFormat) => {
+  if (!ts) return 'Unknown';
+
+  const tsObj = new Date(parseInt(ts, 10));
+  const date = format(tsObj, dateFormat);
+
+  return `${date} ${tsObj.toLocaleTimeString()}`;
+};
+
 type AccountRowProps = {
   account: AccountEntity;
   hovered: boolean;
@@ -20,6 +31,10 @@ export const AccountRow = memo(
     const { t } = useTranslation();
     const backgroundFocus = hovered;
 
+    const dateFormat = useDateFormat() || 'MM/dd/yyyy';
+
+    const lastSync = tsToString(account.last_sync, dateFormat);
+
     return (
       <Row
         height="auto"
@@ -53,11 +68,11 @@ export const AccountRow = memo(
 
         <Cell
           name="stage"
-          width={140}
+          width={200}
           plain
           style={{ color: theme.tableText, padding: '10px' }}
         >
-          {account.account_sync_source ? 'Unknown' : ''}
+          {lastSync}
         </Cell>
 
         {account.account_sync_source ? (

diff --git a/packages/desktop-client/src/components/banksync/AccountsHeader.tsx b/packages/desktop-client/src/components/banksync/AccountsHeader.tsx
@@ -26,7 +26,7 @@ export function AccountsHeader({ unlinked }: AccountsHeaderProps) {
           />
           <Cell
             value={t('Last sync')}
-            width={100}
+            width={160}
             style={{ paddingLeft: '10px' }}
           />
           <Cell value="" width={100} style={{ paddingLeft: '10px' }} />

diff --git a/packages/loot-core/migrations/1738072673000_bank_sync_page.sql b/packages/loot-core/migrations/1738072673000_bank_sync_page.sql
@@ -0,0 +1,5 @@
+BEGIN TRANSACTION;
+
+ALTER TABLE accounts ADD COLUMN last_sync text;
+
+COMMIT;
diff --git a/packages/loot-core/src/client/accounts/accountsSlice.ts b/packages/loot-core/src/client/accounts/accountsSlice.ts
@@ -190,6 +190,8 @@ function handleSyncResponse(
   resMatchedTransactions.push(...matchedTransactions);
   resUpdatedAccounts.push(...updatedAccounts);
 
+  dispatch(getAccounts());
+
   return newTransactions.length > 0 || matchedTransactions.length > 0;
 }
 

diff --git a/packages/loot-core/src/server/aql/schema/index.ts b/packages/loot-core/src/server/aql/schema/index.ts
@@ -73,6 +73,7 @@ export const schema = {
     account_id: f('string'),
     official_name: f('string'),
     account_sync_source: f('string'),
+    last_sync: f('string'),
   },
   categories: {
     id: f('id'),

diff --git a/packages/loot-core/src/server/main.ts b/packages/loot-core/src/server/main.ts
@@ -1045,7 +1045,7 @@ handlers['gocardless-create-web-token'] = async function ({
   }
 };
 
-function handleSyncResponse(
+async function handleSyncResponse(
   res,
   acct,
   newTransactions,
@@ -1060,6 +1060,10 @@ function handleSyncResponse(
   if (added.length > 0) {
     updatedAccounts.push(acct.id);
   }
+
+  const ts = new Date().getTime().toString();
+  const id = acct.id;
+  await db.runQuery(`UPDATE accounts SET last_sync = ? WHERE id = ?`, [ts, id]);
 }
 
 function handleSyncError(err, acct) {
@@ -1127,7 +1131,7 @@ handlers['accounts-bank-sync'] = async function ({ ids = [] }) {
           acct.bankId,
         );
 
-        handleSyncResponse(
+        await handleSyncResponse(
           res,
           acct,
           newTransactions,
@@ -1196,7 +1200,7 @@ handlers['simplefin-batch-sync'] = async function ({ ids = [] }) {
           ),
         );
       } else {
-        handleSyncResponse(
+        await handleSyncResponse(
           account.res,
           accounts.find(a => a.id === account.accountId),
           newTransactions,

diff --git a/packages/loot-core/src/types/models/account.d.ts b/packages/loot-core/src/types/models/account.d.ts
@@ -18,6 +18,7 @@ type _SyncFields<T> = {
   balance_available: T extends true ? number : null;
   balance_limit: T extends true ? number : null;
   account_sync_source: T extends true ? AccountSyncSource : null;
+  last_sync: T extends true ? string : null;
 };
 
 export type AccountSyncSource = 'simpleFin' | 'goCardless';