-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converts html special characters in ofx values to plaintext #2364
Conversation
- Apply during ofx/qfx import
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged No assets were unchanged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the unit tests!
…dget#2364) * Converts html special characters in ofx values to plaintext - Apply during ofx/qfx import
Summary
Converts things like
&
and<
back into plaintext when encountered in qfx/ofx memo or name fields during import.Issue
Fixes #1872
Details
One downside is that users that have payees that are impacted by these characters are going to all of a sudden have additional non-matched payees added when importing with this in place.
Though this could just as easily happen if the banks with these issues fixed their exporters at any point to only have plaintext to begin with.
This change also happens to apply the ampersand replacement in an order that fixes order replacement issues in the source data. (where they did their ampersand replacement after already doing their LT/GT replacement.)
Tests
The example file provided in the issue has been added here as a new test mock.