Magic service query for text search. #1732
Conversation
…so means there are now 2 new Magic Service Queries. This solution works but can be hard to work with in practice. Further refinement necessary for an easy to use MagicServiceQuery that combines both searches.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1732 +/- ##
==========================================
+ Coverage 90.18% 90.25% +0.07%
==========================================
Files 400 402 +2
Lines 38440 38846 +406
Branches 4306 4367 +61
==========================================
+ Hits 34666 35062 +396
Misses 2479 2479
- Partials 1295 1305 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… the respective configs
…ic/qlever into magic-service-query-text-search
…es but in one class.
… of error messages
…roved Error Messages. Added comparison operator for configs which should be removed once unnecessary.
There was a problem hiding this comment.
A review on everything but the tests.
If you need readable output in the tests when something fials,
you either need to overload std::ostream& operator<<(std::ostream&, const YourType&) or implement the PrintTo function for googletest and make it accessible to the tests.
| configVarToConfigs_[subjectVar].isWordSearch_ = false; | ||
| if (object.isLiteral()) { | ||
| configVarToConfigs_[subjectVar].entity_ = | ||
| std::string(asStringViewUnsafe(object.getLiteral().getContent())); |
There was a problem hiding this comment.
Seems to be a missing test case.
| conf.varToBindScore_}); | ||
| } | ||
| } | ||
| return output; |
There was a problem hiding this comment.
The old ql:contains-word has special semantics for strings like "alpha beta blubb*"
wich actually splits into three words "alpha" , "beta" and the prefix "blubb*".
I still have to think what we shall do in this case (Maybe emit a warning, that becomes part of the created config (then you can propagate it in the query planner)
… the output of TextIndexScanForEntity and TextIndexScanForWord. Added more tests to increase code coverage.
Conformance check passed ✅No test result changes. |
|
Add the possibility to do text seach with a magic service query. This leads to two new service queries, one for ql:contains-word and one for ql:contains-entity.