Better transitive path planning #1824
Open
+441
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joka921
requested changes
Feb 21, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1824 +/- ##
==========================================
+ Coverage 90.20% 90.36% +0.15%
==========================================
Files 400 400
Lines 38514 38624 +110
Branches 4319 4338 +19
==========================================
+ Hits 34743 34903 +160
+ Misses 2477 2418 -59
- Partials 1294 1303 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ive-path-planning
…ive-path-planning
joka921
requested changes
Mar 5, 2025
Conformance check passed ✅No test result changes. |
|
joka921
requested changes
Mar 6, 2025
Comment on lines
+169
to
+171
| AD_LOG_WARN << "Tried to re-sort a subtree that will already be sorted " | ||
| "with `Sort` with a different sort order. This is a bug." | ||
| << std::endl; |
There was a problem hiding this comment.
This is not a bug per se but
The reason is possibly a missed optimization in the query planner.
There was a problem hiding this comment.
So please rephrase this, so we don't get that many complaints of innocent users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1809 and #1780
This changes the query planning so that joins are distributively pushed into unions if applicable if the cost is lower this way.