Prepare for supporting chained updates #1841
Open
+105
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1841 +/- ##
==========================================
- Coverage 90.21% 90.21% -0.01%
==========================================
Files 400 400
Lines 38503 38520 +17
Branches 4316 4318 +2
==========================================
+ Hits 34734 34749 +15
Misses 2477 2477
- Partials 1292 1294 +2 ☔ View full report in Codecov by Sentry. |
Conformance check passed ✅No test result changes. |
joka921
requested changes
Mar 4, 2025
Comment on lines
+516
to
+518
| } | ||
|
|
||
| auto update = visit(ctx->update1()); | ||
| auto thisUpdate = visit(ctx->update1()); |
There was a problem hiding this comment.
How easy is it to update this rule also to something non-recursive, s.t. the following code becomes a simple loop?
If feasible, please do so (for readability rather than efficiency, but still)
There was a problem hiding this comment.
The rule only gets a bit longer, but then we'd need something like a reset() function for our state.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required changes in the parsing to be able to support chained updates.