Add check to ensure sorted Distinct input
#1854
Draft
+28
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conformance check passed ✅No test result changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1854 +/- ##
==========================================
- Coverage 90.21% 90.20% -0.01%
==========================================
Files 400 400
Lines 38525 38532 +7
Branches 4323 4323
==========================================
+ Hits 34756 34759 +3
Misses 2477 2477
- Partials 1292 1296 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #1835 (comment) @joka921 we should discuss this. Technically requiring a sorted input is too strict of a requirement. In theory you could have an input that is not sorted, but as long as the same values are grouped together it doesn't matter.
We could automatically add a sort operation when the input is not sufficiently sorted, but there are many possible orders, and we run the risk of choosing a sort order that is suboptimal if we want to expand on the whole "keep sort order only when necessary" thing that is being introduced for
Union.