fix(ffi/ada_free_owned_string): c parameter is passed by value

[pratikpc]

While working on #63, I noticed that my Drop wasn't correctly working because the Rust Implementation was assuming that the C parameters are passed by pointer, while they are actually passed by value

Then on a deeper check of the C code, found it at https://github.com/ada-url/ada/blob/1227f60798b05a04412af867d2f13ed20ead9243/include/ada_c.h#L53C6-L53C27.

BREAKING CHANGE: ada_free_owned_string parameter pass by value not pointer. Closes #64

[anonrig]

Thanks for doing this! Is it easy to add a test for this?

[anonrig]

@steveklabnik can you take a look? :-)

[pratikpc]

@anonrig I tried this approach

I added this to ffi.rs

#[cfg(test)]
mod tests {
    use crate::ffi;

    #[test]
    fn ada_free_owned_string_works() {
        let str = "meßagefactory.ca";
        let result = unsafe {ffi::ada_idna_to_ascii(str.as_ptr().cast(), str.len())};
        assert_eq!(result.as_ref(), "xn--meagefactory-m9a.ca");
        unsafe {ffi::ada_free_owned_string(result)};
    }
}

The previous approach would cause a crash.

I am not sure how correct this is tbh, because it is also dependent on ada_idna_to_ascii but at the end of the day, I think this is the cleanest approach.

[anonrig]

@pratikpc looks good to me. can you add it to the PR?

[pratikpc]

@anonrig done!

[pratikpc]

There were formatting issues

Fixed

Would it be possible to add formatting to the Justfile?

Edit:

Maybe a new MR for the same?

[anonrig]

Would it be possible to add formatting to the Justfile?

Yup

[steveklabnik]

Seems like this got sorted, looks fine to me :)