Fix #148 loop method blocking with timeout of 0 #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjauquet
force-pushed
the
rej-fix-loop-blocking
branch
4 times, most recently
from
284ea42
to
0b26b26
Compare
|
@rjauquet it seems the new version of the test loop script did not pass: https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT/actions/runs/6805249363/job/18504384141#step:2:956 Can you check into that and see what will be required to get it to pass? |
|
Yeah I will have a look today! |
rjauquet
force-pushed
the
rej-fix-loop-blocking
branch
from
0b26b26
to
8185718
Compare
|
I believe the constraint just needed to be loosened now that the timeout is passed through -- the fake method will only be called once as it has the same timeout as the original call instead of always having a timeout of 1 second. |
|
I would approve this if I could. Another friendly ping for the maintainers to take a look. |
brentru
approved these changes
Jan 29, 2024
|
@rjauquet Thank you for this PR. It has been reviewed,approved and merged. A release will follow shortly :) |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 30, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 5.0.6 from 5.0.5: > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#125 from FoamyGuy/recv_timeout Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 4.5.1 from 4.5.0: > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#76 from michalpokusa/routes-refactor Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.5.8 from 7.5.6: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#199 from vladak/loop_vs_keep_alive > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#200 from vladak/loop_timeout_vs_socket_timeout > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#184 from rjauquet/rej-fix-loop-blocking Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 1.0.0 from 0.8.2: > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#61 from Gebhartj/Gebhartj-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks -- I've run into this issue on the Feather RP2040: #148
Not too sure if this is the proper fix for everyone, but this unblocked our team so I thought I'd share a PR. Happy to fix anything up if this isn't quite right.