Handle ESP32SPI Socket.send(), which does not return a byte count #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably it would also be helpful to make ESP32SPI more compliant with the CPython API, but the ESP32SPI library is frozen in to several boards, so this PR is a quicker, more robust fix. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 6, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.11.1 from 7.11.0: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#235 from dhalbert/socket-send-non-int
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#231 assumed☹️ . Thanks @baldengineer and @axelmagnus for testing.
Socket.send()was going to return an int, as it does in CPython. The ESP32SPI version does not