New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test for the PUBLISH+UNSUBACK case #236

Merged

dhalbert merged 1 commit into adafruit:main from vladak:unsuback_vs_publish

Jan 19, 2025

Contributor

vladak commented Jan 19, 2025

This is a follow-up to PR #225


          add test for the PUBLISH+UNSUBACK case

0cd7893

vladak mentioned this pull request

Resolve race condition for UNSUBACK #225

Merged

dhalbert approved these changes

View reviewed changes

Contributor

dhalbert left a comment

Thanks! Tests are always a good idea.

dhalbert merged commit d4b87d2 into adafruit:main

1 check passed

Contributor

dhalbert commented Jan 19, 2025

This PR had a test failure when it was merged: https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT/actions/runs/12854246695/job/35838388261. I think the timing test maybe should be made wider

Contributor Author

vladak commented Jan 19, 2025

will take a look later today.

Contributor Author

vladak commented Jan 19, 2025

This was another case of test_recv_timeout.py failing (i.e. not related to this change), this time with:

FAILED tests/test_recv_timeout.py::RecvTimeout::test_recv_timeout_vs_keepalive - assert (225.125585554 - 216.917325518) <= (8 + 0.2)

so it looks like it would not hurt bumping the adjustment value to 0.3.

dhalbert mentioned this pull request

increase test_recv_timeout delay #238

Open

vladak mentioned this pull request

bump the tolerance for keep alive value in test_recv_timeout.py to 0.3s #239

Open

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@3a9057c)

ba2b6c0

Updating https://github.com/adafruit/Adafruit_CircuitPython_CCS811 to 1.3.18 from 1.3.17:
  > Merge pull request adafruit/Adafruit_CircuitPython_CCS811#52 from jposada202020/adding_displayio_example

Updating https://github.com/adafruit/Adafruit_CircuitPython_ICM20X to 2.1.6 from 2.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_ICM20X#29 from jposada202020/adding_displayio_example

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP9808 to 3.3.26 from 3.3.25:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP9808#39 from jposada202020/adding_displayio_example

Updating https://github.com/adafruit/Adafruit_CircuitPython_MMA8451 to 1.3.23 from 1.3.22:
  > Merge pull request adafruit/Adafruit_CircuitPython_MMA8451#25 from jposada202020/adding_displayio_example

Updating https://github.com/adafruit/Adafruit_CircuitPython_MMC56x3 to 1.0.12 from 1.0.11:
  > Merge pull request adafruit/Adafruit_CircuitPython_MMC56x3#8 from jposada202020/adding_displayio_example

Updating https://github.com/adafruit/Adafruit_CircuitPython_SHTC3 to 1.1.17 from 1.1.16:
  > Merge pull request adafruit/Adafruit_CircuitPython_SHTC3#22 from jposada202020/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_TCA9548A to 0.8.0 from 0.7.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_TCA9548A#55 from rjauquet/rej-add-probe

Updating https://github.com/adafruit/Adafruit_CircuitPython_TCS34725 to 3.3.23 from 3.3.22:
  > Merge pull request adafruit/Adafruit_CircuitPython_TCS34725#44 from jposada202020/adding_displayio_example

Updating https://github.com/adafruit/Adafruit_CircuitPython_TLV493D to 2.0.7 from 2.0.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_TLV493D#19 from jposada202020/adding_displayio_example

Updating https://github.com/adafruit/Adafruit_CircuitPython_TSL2591 to 1.4.2 from 1.4.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_TSL2591#31 from jposada202020/adding_displayio_example

Updating https://github.com/adafruit/Adafruit_CircuitPython_VL53L1X to 1.2.2 from 1.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_VL53L1X#23 from jposada202020/correcting_docs_examples

Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.11.4 from 7.11.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#237 from vladak/remove_recv_into_workaround
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#236 from vladak/unsuback_vs_publish

Updating https://github.com/adafruit/Adafruit_CircuitPython_PixelMap to 1.0.7 from 1.0.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_PixelMap#4 from FoamyGuy/rtd_badge_url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet