Minor cleanup #560
Merged
Minor cleanup #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hathach
reviewed
Aug 25, 2020
| @@ -74,7 +73,7 @@ class TonePwmConfig { | |||
| }; | |||
| TonePwmConfig _pwm_config; | |||
|
|
|||
| inline static bool _is_pwm_enabled(NRF_PWM_Type const * pwm_instance) { | |||
| static bool _is_pwm_enabled(NRF_PWM_Type const * pwm_instance) { | |||
There was a problem hiding this comment.
inline is still OK, it is more like suggestion to gcc. It is up to gcc to decide e.g Ofast may inline the function, but Os may not since it increase the size. attribute always inline is more like directive to gcc to force it to do so. So yeah, it is normally not an issue on non timing-sensitive function. Anyway, I normally just put inline where I would like, and leave the decision to gcc.
hathach
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leftovers from #496.
tone()__attribute__((always_inline)))