-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: Vertical item and custom icon support (fixes #154) #155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition thanks @guywillis and works as expected.
It's no biggie but I wonder whether the class name should be more specific to the element it impacts? For example, the existing image alignment classes specify 'image' in their class name align-image-left
etc. Where as is-center-aligned
is generic. I think it would be useful to include 'button' or 'title' in the class name.
The button and content are both center aligned by the class. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
Do we have the option to have custom icons above the label in the vertical layout? If not can we add? |
Fixes: #154
New
Requires vanilla PR adaptlearning/adapt-contrib-vanilla#530
Proposed vertical item layout solution:
Proposed custom title icons: