Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Remove all cloned descendants on reset #53

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Fix: Remove all cloned descendants on reset #53

merged 3 commits into from
Apr 11, 2024

Conversation

oliverfoster
Copy link
Member

fixes #52

Fix

  • Remove all cloned descendants on reset

@oliverfoster oliverfoster added the bug Something isn't working label Apr 10, 2024
@oliverfoster oliverfoster self-assigned this Apr 10, 2024
@oliverfoster oliverfoster mentioned this pull request Apr 10, 2024
Closed
@oliverfoster @cahirodoherty-learningpool
Update js/BranchingSet.js
8b9c471 
Co-authored-by: Cahir O'Doherty <[email protected]>
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-allen-89
joe-allen-89 approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joe-allen-89 joe-allen-89 merged commit aba0972 into master Apr 11, 2024
@joe-allen-89 joe-allen-89 deleted the issue/52 branch April 11, 2024 08:42
github-actions bot pushed a commit that referenced this pull request Apr 11, 2024
@semantic-release-bot
Chore(release): 1.2.1 [skip ci]
cb9e67b 
## [1.2.1](v1.2.0...v1.2.1) (2024-04-11)

### Fix

* Remove all cloned descendants on reset (#53) ([aba0972](aba0972)), closes [#53](#53)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@danielghost danielghost danielghost approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not correctly removing all branch descendants on reset
4 participants
@oliverfoster @danielghost @cahirodoherty-learningpool @joe-allen-89