Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: role added to component__widget div (fixes #112) #113

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Fix: role added to component__widget div (fixes #112) #113

merged 2 commits into from
Jul 18, 2024

Conversation

joe-allen-89
Copy link
Contributor

#112

Fix

ref:
This is to be consistent to changes made to the slider - adaptlearning/adapt-contrib-slider#210

@joe-allen-89 joe-allen-89 self-assigned this Jul 12, 2024
@joe-allen-89 joe-allen-89 linked an issue Jul 12, 2024 that may be closed by this pull request
screen reader should read out aria-labelledby/label to be consistent with latest slider #112
Closed
@joe-allen-89 joe-allen-89 changed the title Fix: role added to component__widget div (#112) Fix: role added to component__widget div (fixes #112) Jul 12, 2024
This was referenced Jul 15, 2024
Merged
Merged
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

guywillis
guywillis approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joe-allen-89 joe-allen-89 merged commit 4244c1c into master Jul 18, 2024
@joe-allen-89 joe-allen-89 deleted the issue/112 branch July 18, 2024 14:10
github-actions bot pushed a commit that referenced this pull request Jul 18, 2024
@semantic-release-bot
Chore(release): 5.5.3 [skip ci]
cd39aad 
## [5.5.3](v5.5.2...v5.5.3) (2024-07-18)

### Fix

* role added to component__widget div (fixes #112) (#113) ([4244c1c](4244c1c)), closes [#112](#112) [#113](#113) [#112](#112)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@guywillis guywillis guywillis approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@joe-allen-89 joe-allen-89

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

screen reader should read out aria-labelledby/label to be consistent with latest slider
4 participants
@joe-allen-89 @oliverfoster @guywillis @cahirodoherty-learningpool