Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: _isLocked becomes a lockable attribute #585

Merged
merged 3 commits into from
Oct 9, 2024
Merged

New: _isLocked becomes a lockable attribute #585

merged 3 commits into from
Oct 9, 2024

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Sep 25, 2024 •
edited
Loading

part of #584

New

  • _isLocked becomes a lockable attribute allowing plugins to force _isLocked: true

Fix

  • Do not lock when setting initial defaults (this can occur when cloning a model)
  • Make sure to copy locked attribute states on ComponentModel.deepClone
  • Clarified QuestionModel._canSubmit locking as model properties rather than an init function call

Notes

  • The core will softly warn to the console in the period between this change and changing other plugins (trickle) to provide their pluginName when setting _isLocked.

requires adaptlearning/adapt-contrib-trickle#231

@oliverfoster oliverfoster added the enhancement New feature or request label Sep 25, 2024
@oliverfoster oliverfoster self-assigned this Sep 25, 2024
@oliverfoster oliverfoster mentioned this pull request Sep 25, 2024
Merged
@oliverfoster oliverfoster marked this pull request as ready for review September 25, 2024 09:32
swashbuck
swashbuck approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@swashbuck swashbuck merged commit 1cccb8f into master Oct 9, 2024
@swashbuck swashbuck deleted the issue/584 branch October 9, 2024 17:19
github-actions bot pushed a commit that referenced this pull request Oct 9, 2024
@semantic-release-bot
Chore(release): 6.57.0
c7ab17d 
# [6.57.0](v6.56.0...v6.57.0) (2024-10-09)

### New

* _isLocked becomes a lockable attribute (fixes #585) ([1cccb8f](1cccb8f)), closes [#585](#585)
@oliverfoster
Copy link
Member Author

🎉 This PR is included in version 6.57.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@oliverfoster oliverfoster mentioned this pull request Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@joe-replin joe-replin joe-replin approved these changes

@swashbuck swashbuck swashbuck approved these changes

Assignees

@oliverfoster oliverfoster

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliverfoster @swashbuck @joe-replin @cahirodoherty-learningpool