Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Added basic support for _canShowCorrectness #182

Merged
merged 4 commits into from
Oct 8, 2024
Merged

New: Added basic support for _canShowCorrectness #182

merged 4 commits into from
Oct 8, 2024

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Sep 12, 2024 •
edited by kirsty-hames
Loading

part of adaptlearning/adapt_framework#3597

Allows option _canShowCorrectness instead of _canShowModelAnswer, to replace the associated toggle button and display correctness directly on the component.

New

  • Added support for _canShowCorrectness

requires
ref adaptlearning/adapt-contrib-core#582
ref adaptlearning/adapt-contrib-vanilla#528

@oliverfoster oliverfoster self-assigned this Sep 12, 2024
@oliverfoster

This comment was marked as outdated.

Sign in to view
@oliverfoster oliverfoster marked this pull request as ready for review September 12, 2024 14:12
kirsty-hames
kirsty-hames approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected thanks 👍

joe-allen-89
joe-allen-89 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliverfoster oliverfoster merged commit 460d8bd into master Oct 8, 2024
@oliverfoster oliverfoster deleted the issue/3597 branch October 8, 2024 09:58
github-actions bot pushed a commit that referenced this pull request Oct 8, 2024
@semantic-release-bot
Chore(release): 7.6.0 [skip ci]
2afa40c 
# [7.6.0](v7.5.2...v7.6.0) (2024-10-08)

### New

* Added support for _canShowCorrectness (#182) ([460d8bd](460d8bd)), closes [#182](#182)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@simondate simondate simondate approved these changes

Assignees

@oliverfoster oliverfoster

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliverfoster @simondate @kirsty-hames @joe-allen-89