Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Add empty string as valid _target value, remove target property if value is not set (fix #106) #107

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Fix: Add empty string as valid _target value, remove target property if value is not set (fix #106) #107

merged 1 commit into from
Sep 2, 2024

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Aug 20, 2024 •
edited
Loading

Fixes #106

Fix

  • Add empty string as valid _target value in the schemas
  • Remove target attribute from the link element if a value is not set

@swashbuck swashbuck self-assigned this Aug 20, 2024
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Aug 22, 2024
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-allen-89
joe-allen-89 approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joe-allen-89 joe-allen-89 merged commit 4500361 into master Sep 2, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Sep 2, 2024
@semantic-release-bot
Chore(release): 6.2.9 [skip ci]
65e4bea 
## [6.2.9](v6.2.8...v6.2.9) (2024-09-02)

### Fix

* Add empty string as valid _target value, remove target property if value is not set (fixes #107) ([4500361](4500361)), closes [#107](#107)
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

🎉 This PR is included in version 6.2.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@swashbuck swashbuck

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add empty string as an option for the _target value
4 participants
@swashbuck @oliverfoster @cahirodoherty-learningpool @joe-allen-89