Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Use transitionsEnded function instead of transitionend event when setting focus (fixes #314) #315

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Fix: Use transitionsEnded function instead of transitionend event when setting focus (fixes #314) #315

merged 1 commit into from
Aug 28, 2024

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Aug 20, 2024 •
edited
Loading

Fix #314

Fix

  • Use transitionsEnded function instead of the transitionend event when setting focus
  • Bump required Adapt FW version to 5.39.6 due to use of transitionsEnded

Testing

  1. Ensure that repeatedly clicking Previous or Next does not shift the page contents due to the browser trying to find the offscreen element to focus on.
  2. Ensure keyboard navigation + focus is still functional

@swashbuck swashbuck self-assigned this Aug 20, 2024
@swashbuck swashbuck changed the title Fix: Use transitionsEnded instead of transitionend event when setting focus (fixes #314) Fix: Use transitionsEnded function instead of transitionend event when setting focus (fixes #314) Aug 20, 2024
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-allen-89
joe-allen-89 approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 working as expected

@joe-allen-89 joe-allen-89 merged commit 562edec into master Aug 28, 2024
1 check passed
@joe-allen-89 joe-allen-89 deleted the issue/314 branch August 28, 2024 09:56
github-actions bot pushed a commit that referenced this pull request Aug 28, 2024
@semantic-release-bot
Chore(release): 7.10.2 [skip ci]
5e439b8 
## [7.10.2](v7.10.1...v7.10.2) (2024-08-28)

### Fix

* Use transitionsEnded instead of transitionend event when setting focus (fixes #315) ([562edec](562edec)), closes [#315](#315)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@swashbuck swashbuck

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use transitionsEnded instead of transitionend event when setting focus
4 participants
@swashbuck @oliverfoster @cahirodoherty-learningpool @joe-allen-89