Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Marking ticks and mixed configs (fixes #148) #149

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

oliverfoster
Copy link
Member

fixes #148

Fix

  • Marking ticks and mixed configs

Testing

"_answers": [
        ["alpha", "a"],
        ["beta", "b"],
        ["gamma"],
        ["delta", "d"]
    ],
    "_items": [
      {
        "prefix": "pref1",
        "suffix": "suff1",
        "placeholder": "Enter answer here1"
      },
      {
        "prefix": "pref2",
        "suffix": "suff2",
        "placeholder": "Enter answer here2"
      },
      {
        "_answers": [
          "tom",
          "t"
        ],
        "prefix": "pref3",
        "suffix": "suff3",
        "placeholder": "Enter answer here3"
      },
      {
        "prefix": "pref4",
        "suffix": "suff4",
        "placeholder": "Enter answer here4"
      }
    ],

Should show image below (minus correct answer display):
image

@oliverfoster oliverfoster self-assigned this Sep 18, 2024
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the assumption that "gamma" is no longer an acceptable answer for item 3 because answers "t" and "tom" override this. This is working as expected thanks.

@oliverfoster
Copy link
Member Author

oliverfoster commented Sep 18, 2024

With the assumption that "gamma" is no longer an acceptable answer for item 3 because answers "t" and "tom" override this. This is working as expected thanks.

I used this comment as guidance

// Marks any items which have answers specific to it

The rationale is that item specified answers override component specified answers.

Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit a8bd4a1 into master Sep 30, 2024
1 check passed
@oliverfoster oliverfoster deleted the issue/148 branch September 30, 2024 14:04
github-actions bot pushed a commit that referenced this pull request Sep 30, 2024
## [7.2.12](v7.2.11...v7.2.12) (2024-09-30)

### Fix

* Marking ticks and mixed configs (fixes #148) (#149) ([a8bd4a1](a8bd4a1)), closes [#148](#148) [#149](#149)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marking not working correctly on multiple items
4 participants