Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Use parent children instead of stored siblings #213

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Fix: Use parent children instead of stored siblings #213

merged 1 commit into from
Mar 5, 2024

Conversation

oliverfoster
Copy link
Member

fixes adaptlearning/adapt-contrib-assessment#192

Fix

  • Use parent children instead of stored siblings as children are modified by assessment randomisation and banking but siblings are not

@oliverfoster oliverfoster self-assigned this Feb 27, 2024
marissa-champions
marissa-champions approved these changes Feb 28, 2024
View reviewed changes
Copy link

@marissa-champions marissa-champions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Thanks!

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-allen-89
joe-allen-89 approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliverfoster oliverfoster merged commit 4aa09e6 into master Mar 5, 2024
1 check passed
@oliverfoster oliverfoster deleted the issue/192 branch March 5, 2024 11:13
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
@semantic-release-bot
Chore(release): 7.1.2 [skip ci]
f4e75b2 
## [7.1.2](v7.1.1...v7.1.2) (2024-03-05)

### Fix

* Use parent children instead of stored siblings (#213) ([4aa09e6](4aa09e6)), closes [#213](#213)

### Upgrade

* Bump ip from 1.1.8 to 1.1.9 (#212) ([7d6231f](7d6231f)), closes [#212](#212)
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

🎉 This PR is included in version 7.1.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@marissa-champions marissa-champions marissa-champions approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assessment Banks with Trickle Not Unlocking Next Article
4 participants
@oliverfoster @cahirodoherty-learningpool @marissa-champions @joe-allen-89