Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: implement missing _logState condition #225

Merged
merged 1 commit into from
May 29, 2024
Merged

Update: implement missing _logState condition #225

merged 1 commit into from
May 29, 2024

Conversation

danielghost
Copy link
Contributor

@danielghost danielghost commented May 24, 2024 •
edited
Loading

Fixes #194.

Update

  • Implement missing _logState condition to control debug logs and prevent logging as default (as per schemas).

@danielghost danielghost self-assigned this May 24, 2024
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-allen-89
joe-allen-89 approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joe-allen-89 joe-allen-89 merged commit 6690191 into master May 29, 2024
1 check passed
@joe-allen-89 joe-allen-89 deleted the issue/194 branch May 29, 2024 10:50
github-actions bot pushed a commit that referenced this pull request May 29, 2024
@semantic-release-bot
Chore(release): 7.4.0 [skip ci]
c7c1816 
# [7.4.0](v7.3.2...v7.4.0) (2024-05-29)

### Update

* implement missing `_logState` condition (fixes #194). (#225) ([6690191](6690191)), closes [#194](#194) [#225](#225)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 7.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@danielghost danielghost

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_logState not implemented
4 participants
@danielghost @oliverfoster @cahirodoherty-learningpool @joe-allen-89