Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Adapt buttons overhaul (fixes #469) #490

Draft
wants to merge 78 commits into
base: master
Choose a base branch
from
Draft

Commits on Jan 11, 2024

  1. Content item focus and disabled state added

    - focus state inherits from hover (as per existing component focus styles)
    - existing @visited vars are only used by components so grouped with content item
    kirsty-hames authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    8df47a4 View commit details
    Browse the repository at this point in the history
  2. Content button focus, selected, locked and disabled state added

    - focus state inherits from hover (as per existing focus styles)
    - locked state inherits from disabled (as per existing locked styles)
    kirsty-hames authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    31c845f View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Configuration menu
    Copy the full SHA
    2d76066 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    86ded18 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0902920 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fe1cd97 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e2c978c View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. Added item-color mixins

    guywillis committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    c06e250 View commit details
    Browse the repository at this point in the history
  2. Added comments / questions

    guywillis committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    a3206dd View commit details
    Browse the repository at this point in the history
  3. ui color vars replaced

    - Replace @btn-ui-color vars with @ui-color vars. Nav, Notify and Drawer btns inherit from their view colours. This sets an extra level of vars to define global ui colors or edit these separately as per existing Vanilla.
    - rename _buttonStates.less file to _state-mixins.less.
    kirsty-hames committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    aa52dc8 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Added ui button controls mixin

    - ui-btn-controls vars added
    - shared Notify and Drawer btn styles combined into single ui-btn--controls mixin. Replacing .notify-btn-icon mixin.
    kirsty-hames committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    b572119 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    60cabbb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3c48fb9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    98ae77b View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. notify ui btn mixins

    guywillis committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    18046ff View commit details
    Browse the repository at this point in the history
  2. Add item ui mixin

    - set menu item btn vars to inherit from item ui
    kirsty-hames committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    9693002 View commit details
    Browse the repository at this point in the history
  3. Comments updated

    kirsty-hames committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    e051567 View commit details
    Browse the repository at this point in the history
  4. Apply item ui mixin to plugin files

    - item ui locked state added
    - set .narrative__strapline-icon to inherit from narrative__strapline-btn to reduce additional state declaration styles
    kirsty-hames committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    cb29593 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8fd5b33 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    49ee8a7 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    179f634 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6cffe36 View commit details
    Browse the repository at this point in the history
  9. Focus states added to Hotgraphic pin, Media transcript btn, Narrative…

    … controls and strapline
    
    - Narrative strapline icon background color set to transparent to prevent icon background obscuring the btn focus outline
    kirsty-hames committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    49987b0 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    18c9618 View commit details
    Browse the repository at this point in the history
  11. Comment updates

    guywillis committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    4158bfb View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    d21a1d8 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    179bd74 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Configuration menu
    Copy the full SHA
    519156a View commit details
    Browse the repository at this point in the history
  2. Add drawer item vars for margin, padding and border

    - border-radius added
    - default drawer item vars represent current drawer styles
    - margin gives option to display items in a 'button style'
    - when margin is set, apply border to whole of button (not just bottom)
    kirsty-hames committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    b3551cf View commit details
    Browse the repository at this point in the history
  3. Drawer item focus state added

    - drawer item selected state expanded to support aria-current="true" (used by languagepicker which should inherit selected, not disabled styling.
    kirsty-hames committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    9782c7f View commit details
    Browse the repository at this point in the history
  4. Update glossary padding vars

    ...to align with drawer item padding
    kirsty-hames committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    e22f330 View commit details
    Browse the repository at this point in the history
  5. Comment updates

    kirsty-hames committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    b827321 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Notify btn mixin

    guywillis committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    d690bcc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    13bd381 View commit details
    Browse the repository at this point in the history
  3. Comments

    guywillis committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    8f165ac View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. comments

    kirsty-hames committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    d571965 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e4773b5 View commit details
    Browse the repository at this point in the history
  3. Resource drawer item mixins

    guywillis committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    0970ecd View commit details
    Browse the repository at this point in the history
  4. Typo fix

    guywillis committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    8f880e1 View commit details
    Browse the repository at this point in the history
  5. comments

    kirsty-hames committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    6956e5d View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Configuration menu
    Copy the full SHA
    d5c5903 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ff3a3cf View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Configuration menu
    Copy the full SHA
    15b2c62 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    68a2b52 View commit details
    Browse the repository at this point in the history
  3. Added missing focus states

    guywillis committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    100acfa View commit details
    Browse the repository at this point in the history
  4. Matching dropdown updates

    guywillis committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    0ed9e97 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1fc4e70 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. trickle btn locked state added

    following PR merge, 'is-locked' btn class added - adaptlearning/adapt-contrib-trickle#209
    kirsty-hames authored Mar 12, 2024
    Configuration menu
    Copy the full SHA
    f38a49b View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Button expanded mixin test

    guywillis committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    b792f4f View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. Configuration menu
    Copy the full SHA
    7662a70 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Configuration menu
    Copy the full SHA
    dc894f2 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Configuration menu
    Copy the full SHA
    2efbabf View commit details
    Browse the repository at this point in the history
  2. btn styles added to state mixins

    - outline and plain styles added to existing mixins still tbc
    - TODO and query comments added
    - border width and color vars added
    kirsty-hames committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    fc1e008 View commit details
    Browse the repository at this point in the history
  3. btn styles added to state mixins

    - outline and plain styles added to existing mixins
    - border width and color vars added
    kirsty-hames committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    1690fd3 View commit details
    Browse the repository at this point in the history
  4. notify ui disabled state added

    ...used for Hotgraphic controls first/last item
    kirsty-hames committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    810935e View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Configuration menu
    Copy the full SHA
    2c57639 View commit details
    Browse the repository at this point in the history
  2. remove unused btn outline 'border-color' vars

    ...mixins inherit from their state color var instead
    kirsty-hames committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    005df49 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    629f915 View commit details
    Browse the repository at this point in the history
  4. nav ui mixin name change for consistency with other color variable na…

    …ming
    
    ...changed to 'ui-btn-ctrl-color' for consistency with other color variable naming and consistency with .ui-btn-ctrl;
    kirsty-hames committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    3ac95e6 View commit details
    Browse the repository at this point in the history
  5. nav ui mixin name change for consistency with other color variable na…

    …ming
    
    ...changed to 'ui-btn-ctrl-color' for consistency with other color variable naming and consistency with .ui-btn-ctrl;
    kirsty-hames committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    643fb67 View commit details
    Browse the repository at this point in the history
  6. button styles applied to _defaults and core files

    - temp button style vars added - naming tbc
    - drawer item locked state added
    kirsty-hames committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    da3a525 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. button styles applied to plugin files

    - missing item border-width var added
    - @menu-item-btn-style var name fix
    - missing btn state mixins added
    - notify btn style var fix
    - comments added
    kirsty-hames committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    08862f5 View commit details
    Browse the repository at this point in the history
  2. todo comment update

    kirsty-hames committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    1f3ccf5 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Button styles updated

    guywillis committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    6e574d2 View commit details
    Browse the repository at this point in the history
  2. Small optimisations

    guywillis committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    f060ca1 View commit details
    Browse the repository at this point in the history
  3. // ! todo comment updates

    guywillis committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    1db3254 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Added less style vars

    guywillis committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    45c319d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0845a76 View commit details
    Browse the repository at this point in the history
  3. Test code optimisation

    guywillis committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    08d8f85 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    38a50ce View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Code optimisation

    guywillis committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    1840735 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. button border width variable amends

    - share border-width variable between drawer and notify UI button controls
    - remove reference to 'color' from border width variables
    - change reference from 'icon' to 'btn' for nav ui border-width variable for consistency with other nav btn spacing variables
    - move border-width variables into spacing less
    - set menu item to inherit its own border-radius variable
    kirsty-hames committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    b8e02e7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f95324e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2abcfad View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Configuration menu
    Copy the full SHA
    d0cbb38 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Configuration menu
    Copy the full SHA
    4d0ddd5 View commit details
    Browse the repository at this point in the history
  2. Resource comment updated

    guywillis committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    7c32672 View commit details
    Browse the repository at this point in the history
  3. Border radius update

    guywillis committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    39351d2 View commit details
    Browse the repository at this point in the history