Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JS bundling and minification with Rollup #48

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Add JS bundling and minification with Rollup #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c79032d
DRND-208 add toolig for js bundling to improve load perofrmance
mbehzad Feb 27, 2023
2d3d4c3
add generated files
mbehzad Feb 27, 2023
8693871
add generated files
mbehzad Feb 27, 2023
9711bfb
fix lint issue
mbehzad Feb 28, 2023
0eeba46
DRND-208 JS bundling
mbehzad Mar 1, 2023
624ce77
DRND-208 Tooling
mbehzad Mar 2, 2023
7b3e097
DRND-208 Tooling
mbehzad Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
helix-importer-ui
scripts/3rdparty/**
scripts/3rdparty/**
target/**
8 changes: 8 additions & 0 deletions .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

# build js artefacts
npm run build

# add them to the commit
git add 'target'
9 changes: 7 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
adaptTo() Website based on AEM Franklin.

## Environments

- Preview: https://main--adaptto-website--adaptto.hlx.page/
- Live: https://main--adaptto-website--adaptto.hlx.live/

Expand All @@ -22,6 +23,10 @@ npm tst

## Local development

1. Install the [Helix CLI](https://github.com/adobe/helix-cli): `npm install -g @adobe/helix-cli`
2. Start Franklin Proxy: `hlx up` (opens your browser at `http://localhost:3000`)
```sh
npm start
```

1. run `npm start` which uses the [Helix CLI](https://github.com/adobe/helix-cli)
2. open your browser at `http://localhost:3000` to access the Franklin Proxy
3. Open the `adaptto-website` directory in your favorite IDE and start coding :)
9 changes: 6 additions & 3 deletions head.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
<meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1, user-scalable=no"/>
<script src="/scripts/lib-franklin.js" type="module"></script>
<script src="/scripts/scripts.js" type="module"></script>
<!--
lib-franklin is already loaded by script.js. and doensn't necceserly nedds to be included here
<script src="/target/lib-franklin.js" type="module"></script>
-->
<script src="/target/scripts.js" type="module"></script>
<link rel="stylesheet" href="/styles/styles.css">
<link rel="shortcut icon" href="/resources/img/adaptto-favicon.ico"/>
<link rel="icon" type="image/svg+xml" href="/resources/img/adaptto-favicon.svg">
<link rel="apple-touch-icon" href="/resources/img/apple-touch-icon-57-57.png">
<link rel="apple-touch-icon" href="/resources/img/apple-touch-icon-72x72.png" sizes="72x72">
<link rel="apple-touch-icon" href="/resources/img/apple-touch-icon-114x114.png" sizes="114x114">
<link rel="apple-touch-icon" href="/resources/img/apple-touch-icon-114x114.png" sizes="114x114">
Loading