Combined updates with iOS & Android support #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inline return
Changed URL for git clone command, correction of a typo
Allow registering certificate from any path, for example documents directory. This enables dynamically adding a certificate.
Update readme
Enable persistent identity storage in keychain
continue if user pressed cancel on certification selection dialog.
with the needed onload param setting
- updated section headers - add subsection headers - show installation of plugin from GitHub (no need to make a local clone in case plugin is used in production) - add a warning that the client certificate should NEVER be included in any part of a published app - minor formatting fixes - updated links to Cordova documentation - remove trailing whitespace
and remove an extra blank line
and remove extra line from end of JavaScript sample
WITH the following updates to README.md: - NOTICE that Android implementation is not tested with JavaScript updates from mwaylabs/cordova-plugin-client-certificate - ADD quick labels for alternative samples - FIX second alternative sample due to API change from mwaylabs/cordova-plugin-client-certificate
in package.json & plugin.xml
- Remove extra fork info - Document that this plugin version uses `config-file` elements to configure the app to handle open requests for the custom `myp12` extension, on iOS only - Clarify possible issues on Android platform - Move and update TODO items - Update sample subheaders - Better comment about updated API in second sample - Additional items for future consideration
- add pluginInitialize method with logging - replace existing printf logging with NSLog - add some more log messages - add blank lines - #ifdef out readDirectoryContent - comment out code not used
Note that some of the code for iOS is under Apple MIT License ref: https://spdx.org/licenses/AML.html
This is a "mashup merge" which combines Android-specific plugin version together with a plugin version designed for iOS, with a series of fork updates. The --allow-unrelated-histories option was used to combine (merge togeher) from plugins with unrelated histories. This merge is based on the Android-specific plugin version in order for git blame to show the correct author.
Co-authored-by: Johannes Staehlin <[email protected]> Co-authored-by: Christopher J. Brody <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from various forks, as needed by a major customer