Skip to content

Commit

Permalink
PHP 8 (#45)
Browse files Browse the repository at this point in the history
* "php": ">=7.2"

* RELEASENOTES for PHP8 installability

* Run multiple php versions in composer_test CI

* "php": ">=7.3"

We can't test in CI with 7.2
Also it is no longer supported anyway...

* Fix 1 failing test in PHP8

* Fix .github/workflows/composer_test.yaml

* Some slightly better Github Action names

* Require guzzle 6.3+ in order to make tests pass
  • Loading branch information
addwiki-ci committed Feb 16, 2021
1 parent 86f05f0 commit 3da3a08
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
5 changes: 5 additions & 0 deletions RELEASENOTES.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Release Notes

## Version 2.8 (16 February 2021)

- Installable with 7.3+ (including PHP8)
- Installable with `guzzlehttp/guzzle` `~6.3|~7.0`

## Version 2.7 (15 February 2021)

- Installable with `guzzlehttp/guzzle` `~6.0|~7.0`
Expand Down
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
]
},
"require": {
"php": "^7.2",
"guzzlehttp/guzzle": "~6.0|~7.0",
"php": ">=7.3",
"guzzlehttp/guzzle": "~6.3|~7.0",
"guzzlehttp/promises": "~1.0",
"psr/log": "~1.0"
},
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/MediawikiApiTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,6 @@ public function testLogWarningsWithWarningsDeeperInTheArray() {
$method = $reflection->getMethod( 'logWarnings' );
$method->setAccessible( true );

$method->invokeArgs( $api, $input );
$method->invokeArgs( $api, [ $input ] );
}
}

0 comments on commit 3da3a08

Please sign in to comment.