Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing CoroutineScopes with viewModelScope #58

Merged

Conversation

Mrtckr008
Copy link
Contributor

Based on #22

Problem

Using CoroutineScope instead of using viewModelScope inside viewModel.

Solution

The replacement has been made based on the following description;
Using a viewModelScope within a ViewModel is a more convenient, safer, and easier way to create and manage a CoroutineScope. viewModelScope automatically cancels processes and ensures that they are run on the correct thread, so it's the more preferred approach overall.

Test

Tested whole application features on Google Pixel 3.

@Mrtckr008 Mrtckr008 self-assigned this Jun 20, 2023
@Mrtckr008 Mrtckr008 marked this pull request as ready for review June 20, 2023 08:24
@Mrtckr008 Mrtckr008 force-pushed the feature/viewModelScope-replacement-with-CoroutineScope branch from 301afa6 to a410510 Compare August 8, 2023 10:52
@Mrtckr008 Mrtckr008 merged commit dee47d6 into develop Aug 8, 2023
@Mrtckr008 Mrtckr008 deleted the feature/viewModelScope-replacement-with-CoroutineScope branch August 8, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants